From c11f379e7e731bbdde2aef167f5df9d19e257318 Mon Sep 17 00:00:00 2001
From: bixiaoyan <bixiaoyan@kylinos.cn>
Date: Mon, 31 Mar 2025 09:54:25 +0800
Subject: [PATCH] Fix remote script generator return information parsing error

---
 models/scripts.go | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/models/scripts.go b/models/scripts.go
index fa2844e..c1ced00 100644
--- a/models/scripts.go
+++ b/models/scripts.go
@@ -239,7 +239,7 @@ func GenerateScript(data map[string]string) ScriptResponse {
 		utils.LogTraceWithMsg(err, "get hostname failed")
 		return ScriptResponse{
 			GeneralResponse: utils.GeneralResponse{
-				Action: true,
+				Action: false,
 				Error:  gettext.Gettext("get hostname failed"),
 			},
 		}
@@ -300,20 +300,23 @@ func GenerateScript(data map[string]string) ScriptResponse {
 				result[nodeName] = gettext.Gettext("Generate script failed")
 				continue
 			}
-			retMap["action"] = retMap["action"].(bool)
-			if retMap["action"].(bool) {
-				result[nodeName] = gettext.Gettext("Generate script success")
-			} else {
+			// actionVal, exist := retMap["action"]
+			if retMap != nil {
 				result[nodeName] = gettext.Gettext("Generate script failed")
+			} else {
+				result[nodeName] = gettext.Gettext("Generate script success")
 			}
+			// if !exist || (exist && !actionVal.(bool)) {
+			// 	result[nodeName] = gettext.Gettext("Generate script failed")
+			// } else {
+			// 	result[nodeName] = gettext.Gettext("Generate script success")
+			// }
 		}
 	}
-
 	return ScriptResponse{
 		Data: result,
 		GeneralResponse: utils.GeneralResponse{
-			Action: len(result) == 0,
+			Action: true,
 		},
 	}
-
 }
-- 
Gitee